Skip to content

Conversation

eddelbuettel
Copy link
Member

No description provided.

eddelbuettel added a commit that referenced this pull request Nov 24, 2014
@eddelbuettel eddelbuettel merged commit ac57968 into master Nov 24, 2014
@eddelbuettel eddelbuettel deleted the feature/four-part-version-macro branch November 24, 2014 01:15
@eddelbuettel eddelbuettel mentioned this pull request Nov 24, 2014
@eddelbuettel
Copy link
Member Author

Oh, and for what it is worth even the old one support Rcpp_Version(0, 11, 3.2).

So could you dial down your test in dplyr so that we can set Rcpp_Version to 0.11.3.2 and/or use RcppDevVersion(0,11,3,2) >= RCPP_DEV_VERSION ?

@romainfrancois
Copy link
Contributor

Have you actually tried Rcpp_Version(0, 11, 3.2) actually. Pretty sure you can't have floating point in the preprocessor. Fool me once ...

romainfrancois added a commit to tidyverse/dplyr that referenced this pull request Nov 24, 2014
@romainfrancois
Copy link
Contributor

I'm just using #ifndef TINYFORMAT_H_INCLUDED good enough. In the future I might use your RCPP_DEV_VERSION but I guess I can only use this starting from next version ...

@eddelbuettel
Copy link
Member Author

Thanks for no longer requiring the somewhat incorrect (0,11,4). For reference you can now use this:

R> evalCpp("RcppDevVersion(0,11,3,2) >= RCPP_DEV_VERSION")
[1] TRUE
R> evalCpp("RcppDevVersion(0,11,3,1) >= RCPP_DEV_VERSION")
[1] FALSE
R> 

I'll probably define the standard versions as a variant of these containing a final zero.

eddelbuettel added a commit that referenced this pull request Nov 24, 2014
jmp75 pushed a commit to jmp75/Rcpp that referenced this pull request Mar 16, 2015
…on-macro

Feature/four part version macro
jmp75 pushed a commit to jmp75/Rcpp that referenced this pull request Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants