Skip to content

Conversation

1dayac
Copy link

@1dayac 1dayac commented Mar 18, 2015

Commit to fix the issue - "Matrix default ctor does not make a matrix #129"

@eddelbuettel
Copy link
Member

Looks good to me. Does not do a whole lot, but appears to fix #129.

Any seconds -- @kevinushey or @jjallaire ?

@kevinushey
Copy link
Contributor

Looks good to me.

@eddelbuettel
Copy link
Member

Now folding in PR after second LGTM over email.

As for GSoC we need more discussion and a plan. If you are interested, I would invite to open the discussion with a new issue ticket in the Rcpp GitHub repository where you flesh out the proposal, and we can comment.

We on the Rcpp Core are prudent about making breaking changes. As such, some proposals and ideas are better than others. The new DataFrame class may be a good candidate as we can test it at length in a add-on package rather than having to make changes in Rcpp itself. For the same reason R_xlen_t is tricky. I just expanded the Extend Rcpp entry on the GSoC WIki a little in regards to this.

eddelbuettel added a commit that referenced this pull request Mar 22, 2015
Default ctor for Matrix return 0x0 matrix
@eddelbuettel eddelbuettel merged commit 01bd959 into RcppCore:master Mar 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants