Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address issue #350 by renaming Modules #351

Merged
merged 2 commits into from
Aug 26, 2015

Conversation

eddelbuettel
Copy link
Member

affects four different unit tests
also very minor cleanups

affects four different unit tests
also very minor cleanups
@eddelbuettel
Copy link
Member Author

Interesting. So it fails at Travis while it passes here at on my box. I'll separate out more modules then -- now that World is taken care of this crashed over Num.

@eddelbuettel eddelbuettel changed the title address issue #350 by renaming 'World' Modules address issue #350 by renaming Modules Aug 26, 2015
@eddelbuettel
Copy link
Member Author

@kevinushey @jjallaire Let me know what you think -- this ought to be ready to merge.

That said -- I am running a rev.dep now which I started before I noticed the need for the second commit. Current status is 270 out 449 good, 15 bad, rest pending -- which looks in-line with the last full check in July. So we may as well wait the few more hours until this completes.

@kevinushey
Copy link
Contributor

Looks good to me.

@eddelbuettel
Copy link
Member Author

Rev.deps finished fine, logs and summary committed in RcppCore/rcpp-logs@ebbce0c

No new issues that were caused by Modules; there is one package which fails it tests for an odd reason I couldn;t immediately attribute.

eddelbuettel added a commit that referenced this pull request Aug 26, 2015
@eddelbuettel eddelbuettel merged commit 17ef95e into master Aug 26, 2015
@eddelbuettel eddelbuettel deleted the bugfix/unique-modules-names branch August 28, 2015 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants