fix wrong return type in product of dimensions #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't matter. Very few people are using that large vector or matrix. It will be appreciated it you can test more. |
|
I am working on an R package which processes very large matrices. |
|
@eddelbuettel Can you look at this? |
|
@thirdwing I sort-of had. I think it is good as is. |
|
Looks good to me. |
eddelbuettel
added a commit
that referenced
this pull request
Sep 23, 2015
fix wrong return type in product of dimensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry guys...
I should have tested it first.