Add extra checks to demangler_one #412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly rewrite demangler_one function to use std::string::substr instead of std::string::resize and std::string::erase. For instance, if the output of backtrace_symbols doesn't contain "+" for some reason (e.g. the symbol table is missing), the function crashed with std::length_error in resize(). If the string doesn't contain spaces, it could also crash in the subsequent call to erase().
Revert to resize/erase, but introduce checks against std::string::npos.
|
We prefer issue tickets being opened before pull requests. Can you (and post it just here) please motivate why we want a change and what you want to change? A reproducible example would not hurt either. Lastly, you may have noticed that your pull request failed the continuous integration test, so in order for this to be considered you probably want to correct that. |
|
|
|
Sure, sorry for the noise. I will follow up with more precise problem description, and updated patch shortly. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be more defensive about the output of backtrace_symbols, passed to demangler_one: don't assume the string would always have plus sign and space (e.g. the symbol may be unavailable) to prevent against crashes (e.g. resize would throw std::length_error for std::string::npos - 1).