-
-
Notifications
You must be signed in to change notification settings - Fork 219
Sugar median with unit tests #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,290 @@ | ||
// -*- mode: C++; c-indent-level: 4; c-basic-offset: 4; indent-tabs-mode: nil; -*- | ||
// | ||
// median.h: Rcpp R/C++ interface class library -- median | ||
// | ||
// Copyright (C) 2016 Dirk Eddelbuettel, Romain Francois, and Nathan Russell | ||
// | ||
// This file is part of Rcpp. | ||
// | ||
// Rcpp is free software: you can redistribute it and/or modify it | ||
// under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 2 of the License, or | ||
// (at your option) any later version. | ||
// | ||
// Rcpp is distributed in the hope that it will be useful, but | ||
// WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
// | ||
// You should have received a copy of the GNU General Public License | ||
// along with Rcpp. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
#ifndef Rcpp__sugar__median_h | ||
#define Rcpp__sugar__median_h | ||
|
||
namespace Rcpp { | ||
namespace sugar { | ||
namespace median_detail { | ||
|
||
// need to return double for integer vectors | ||
// (in case of even-length input vector) | ||
// and Rcpp::String for STRSXP | ||
// also need to return NA_REAL for | ||
// integer vector yielding NA result | ||
template <int RTYPE> | ||
struct result { | ||
typedef typename Rcpp::traits::storage_type<RTYPE>::type type; | ||
enum { rtype = RTYPE }; | ||
}; | ||
|
||
template <> | ||
struct result<INTSXP> { | ||
typedef double type; | ||
enum { rtype = REALSXP }; | ||
}; | ||
|
||
template <> | ||
struct result<STRSXP> { | ||
typedef Rcpp::String type; | ||
enum { rtype = STRSXP }; | ||
}; | ||
|
||
// std::nth_element and std::max_element don't | ||
// know how to compare Rcomplex values | ||
template <typename T> | ||
inline bool less(T lhs, T rhs) { | ||
return lhs < rhs; | ||
} | ||
|
||
template<> | ||
inline bool less<Rcomplex>(Rcomplex lhs, Rcomplex rhs) { | ||
if (lhs.r < rhs.r) return true; | ||
if (lhs.i < rhs.i) return true; | ||
return false; | ||
} | ||
|
||
// compiler does not know how to handle | ||
// Rcomplex numerator / double denominator | ||
// and need explicit cast for INTSXP case | ||
inline double half(double lhs) { | ||
return lhs / 2.0; | ||
} | ||
|
||
inline double half(int lhs) { | ||
return static_cast<double>(lhs) / 2.0; | ||
} | ||
|
||
inline Rcomplex half(Rcomplex lhs) { | ||
lhs.r /= 2.0; | ||
lhs.i /= 2.0; | ||
return lhs; | ||
} | ||
|
||
} // median_detail | ||
|
||
// base case | ||
template <int RTYPE, bool NA, typename T, bool NA_RM = false> | ||
class Median { | ||
public: | ||
typedef typename median_detail::result<RTYPE>::type result_type; | ||
typedef typename Rcpp::traits::storage_type<RTYPE>::type stored_type; | ||
enum { RESULT_RTYPE = median_detail::result<RTYPE>::rtype }; | ||
typedef T VECTOR; | ||
|
||
private: | ||
VECTOR x; | ||
|
||
public: | ||
Median(const VECTOR& xx) | ||
: x(Rcpp::clone(xx)) {} | ||
|
||
operator result_type() { | ||
if (x.size() < 1) { | ||
return Rcpp::traits::get_na<RESULT_RTYPE>(); | ||
} | ||
|
||
if (Rcpp::any(Rcpp::is_na(x))) { | ||
return Rcpp::traits::get_na<RESULT_RTYPE>(); | ||
} | ||
|
||
R_xlen_t n = x.size() / 2; | ||
std::nth_element( | ||
x.begin(), x.begin() + n, x.end(), | ||
median_detail::less<stored_type>); | ||
|
||
if (x.size() % 2) return x[n]; | ||
return median_detail::half( | ||
x[n] + *std::max_element( | ||
x.begin(), x.begin() + n, | ||
median_detail::less<stored_type>)); | ||
} | ||
}; | ||
|
||
// na.rm = TRUE | ||
template <int RTYPE, bool NA, typename T> | ||
class Median<RTYPE, NA, T, true> { | ||
public: | ||
typedef typename median_detail::result<RTYPE>::type result_type; | ||
typedef typename Rcpp::traits::storage_type<RTYPE>::type stored_type; | ||
enum { RESULT_RTYPE = median_detail::result<RTYPE>::rtype }; | ||
typedef T VECTOR; | ||
|
||
private: | ||
VECTOR x; | ||
|
||
public: | ||
Median(const VECTOR& xx) | ||
: x(Rcpp::na_omit(Rcpp::clone(xx))) {} | ||
|
||
operator result_type() { | ||
if (!x.size()) { | ||
return Rcpp::traits::get_na<RESULT_RTYPE>(); | ||
} | ||
|
||
R_xlen_t n = x.size() / 2; | ||
std::nth_element( | ||
x.begin(), x.begin() + n, x.end(), | ||
median_detail::less<stored_type>); | ||
|
||
if (x.size() % 2) return x[n]; | ||
return median_detail::half( | ||
x[n] + *std::max_element( | ||
x.begin(), x.begin() + n, | ||
median_detail::less<stored_type>)); | ||
} | ||
}; | ||
|
||
// NA = false | ||
template <int RTYPE, typename T, bool NA_RM> | ||
class Median<RTYPE, false, T, NA_RM> { | ||
public: | ||
typedef typename median_detail::result<RTYPE>::type result_type; | ||
typedef typename Rcpp::traits::storage_type<RTYPE>::type stored_type; | ||
enum { RESULT_RTYPE = median_detail::result<RTYPE>::rtype }; | ||
typedef T VECTOR; | ||
|
||
private: | ||
VECTOR x; | ||
|
||
public: | ||
Median(const VECTOR& xx) | ||
: x(Rcpp::clone(xx)) {} | ||
|
||
operator result_type() { | ||
if (x.size() < 1) { | ||
return Rcpp::traits::get_na<RESULT_RTYPE>(); | ||
} | ||
|
||
R_xlen_t n = x.size() / 2; | ||
std::nth_element( | ||
x.begin(), x.begin() + n, x.end(), | ||
median_detail::less<stored_type>); | ||
|
||
if (x.size() % 2) return x[n]; | ||
return median_detail::half( | ||
x[n] + *std::max_element( | ||
x.begin(), x.begin() + n, | ||
median_detail::less<stored_type>)); | ||
} | ||
}; | ||
|
||
// specialize for character vector | ||
// due to string_proxy's incompatibility | ||
// with certain std:: algorithms; | ||
// need to return NA for even-length vectors | ||
template <bool NA, typename T, bool NA_RM> | ||
class Median<STRSXP, NA, T, NA_RM> { | ||
public: | ||
typedef typename median_detail::result<STRSXP>::type result_type; | ||
typedef typename Rcpp::traits::storage_type<STRSXP>::type stored_type; | ||
typedef T VECTOR; | ||
|
||
private: | ||
VECTOR x; | ||
|
||
public: | ||
Median(const VECTOR& xx) | ||
: x(Rcpp::clone(xx)) {} | ||
|
||
operator result_type() { | ||
if (!(x.size() % 2)) { | ||
return Rcpp::traits::get_na<STRSXP>(); | ||
} | ||
|
||
if (Rcpp::any(Rcpp::is_na(x))) { | ||
return Rcpp::traits::get_na<STRSXP>(); | ||
} | ||
|
||
R_xlen_t n = x.size() / 2; | ||
x.sort(); | ||
|
||
return x[n]; | ||
} | ||
}; | ||
|
||
// na.rm = TRUE | ||
template <bool NA, typename T> | ||
class Median<STRSXP, NA, T, true> { | ||
public: | ||
typedef typename median_detail::result<STRSXP>::type result_type; | ||
typedef typename Rcpp::traits::storage_type<STRSXP>::type stored_type; | ||
typedef T VECTOR; | ||
|
||
private: | ||
VECTOR x; | ||
|
||
public: | ||
Median(const VECTOR& xx) | ||
: x(Rcpp::na_omit(Rcpp::clone(xx))) {} | ||
|
||
operator result_type() { | ||
if (!(x.size() % 2)) { | ||
return Rcpp::traits::get_na<STRSXP>(); | ||
} | ||
|
||
R_xlen_t n = x.size() / 2; | ||
x.sort(); | ||
|
||
return x[n]; | ||
} | ||
}; | ||
|
||
// NA = false | ||
template <typename T> | ||
class Median<STRSXP, false, T, true> { | ||
public: | ||
typedef typename median_detail::result<STRSXP>::type result_type; | ||
typedef typename Rcpp::traits::storage_type<STRSXP>::type stored_type; | ||
typedef T VECTOR; | ||
|
||
private: | ||
VECTOR x; | ||
|
||
public: | ||
Median(const VECTOR& xx) | ||
: x(Rcpp::clone(xx)) {} | ||
|
||
operator result_type() { | ||
if (!(x.size() % 2)) { | ||
return Rcpp::traits::get_na<STRSXP>(); | ||
} | ||
|
||
R_xlen_t n = x.size() / 2; | ||
x.sort(); | ||
|
||
return x[n]; | ||
} | ||
}; | ||
|
||
} // sugar | ||
|
||
template <int RTYPE, bool NA, typename T> | ||
inline typename sugar::median_detail::result<RTYPE>::type | ||
median(const Rcpp::VectorBase<RTYPE, NA, T>& x, bool na_rm = false) { | ||
if (!na_rm) return sugar::Median<RTYPE, NA, T, false>(x); | ||
return sugar::Median<RTYPE, NA, T, true>(x); | ||
} | ||
|
||
} // Rcpp | ||
|
||
#endif // Rcpp__sugar__median_h |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm -- we clone the vector here because the
std::
algorithm we use will modify the passed vector?