fix the error in subset under gc. close #431 #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work. Do you think this can go in without fear of side-effects? And I can always run another rev.dep check as well. |
|
Looks good to me -- I don't think there will be any issues. |
|
Right. I'll merge now and set it up to burn some cycles. Thanks a big fat bunch to both of you for chasing this one down so quickly. |
eddelbuettel
added a commit
that referenced
this pull request
Jan 30, 2016
fix the error in subset under gc. close #431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simpler solution. We can close this if we figure out how to reuse the IntergerVector correctly.
@kevinushey @eddelbuettel