-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support R 3.3.0 Windows new toolchain #451
Conversation
if (isGcc49) { | ||
env$RTOOLS <- .rtoolsPath(rToolsPath) | ||
binpref <- ifelse(identical(R.Version()$arch, "x86_64"), "mingw_64", "mingw_32") | ||
env$BINPREF <- file.path(env$RTOOLS, binpref, "bin//", fsep = "/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking -- is the double slash, in "bin//"
, really necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, without //
, then will show this:
c:/Rtools//mingw_64/bing++ -I"C:/PROGRA~1/R/R-33~1.0AL/include" -DNDEBUG -I"C:/Users/outwen/Documents/R/win-library/3.3/Rcpp/include" -I"C:/Users/outwen/AppData/Local/Temp/RtmpWk5CaT" -I"d:/Compiler/gcc-4.9.3/local330/include" -O2 -Wall -mtune=core2 -c file2680116e76f7.cpp -o file2680116e76f7.o
c:/Rtools//mingw_64/bing++: not found
make: *** [file2680116e76f7.o] Error 127
Warning message:
running command 'make -f "C:/PROGRA~1/R/R-33~1.0AL/etc/x64/Makeconf" -f "C:/PROGRA~1/R/R-33~1.0AL/share/make/winshlib.mk" SHLIB_LDFLAGS='$(SHLIB_CXXLDFLAGS)' SHLIB_LD='$(SHLIB_CXXLD)' SHLIB="sourceCpp_1.dll" WIN=64 TCLBIN=64 OBJECTS="file2680116e76f7.o"' had status 2
Error in sourceCpp(code = "\n #include <Rcpp.h>\n\n // [[Rcpp::export]]\n int fibonacci(const int x) {\n if (x == 0) return(0);\n if (x == 1) return(1);\n return (fibonacci(x - 1)) + fibonacci(x - 2);\n }") :
Error 1 occurred building shared library.
WARNING: The tools required to build C++ code for R were not found.
Please download and install the appropriate version of Rtools:
http://cran.r-project.org/bin/windows/Rtools/
ca47e5c
to
cce9cd8
Compare
Also tested with R 3.2.4 for Windows with Rtools 3.3. |
You can actually include the $(WIN) argument within BINPREF to have R On Sun, Mar 27, 2016 at 2:28 AM, qinwf notifications@github.com wrote:
|
R 3.3.0 Windows uses a new toolchain based on gcc 4.9.3 and mingw-w64 v3.
229fb87
to
d3c4bd1
Compare
Thanks @jjallaire , just update it. |
Nice, thanks! |
Tested with R-3.3.0 alpha build for Windows with Rtools 3.3.