Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R/Module.R: avoid calling as.character on a C++Object #461

Merged
merged 1 commit into from
Apr 13, 2016

Conversation

bgoodri
Copy link
Contributor

@bgoodri bgoodri commented Apr 13, 2016

This fixes a mysterious race on Debian unstable with R 3.3.0 beta
that was triggered when loading the rstanarm package

Closes #458

This fixes a mysterious race on Debian unstable with R 3.3.0 beta
that was triggered when loading the rstanarm package

Closes RcppCore#458
@eddelbuettel
Copy link
Member

Thanks so much for submitting the PR.

I'll try to get some feedback from those more knowledgeable than me about Reference Classes / S4, but will also give it the full test treatment. Will some luck this should be in a 0.12.5 release around the time R 3.3.0 comes out.

@eddelbuettel
Copy link
Member

Full reverse dependency check passed: 626 packages with no issues, 7 with various issues:

  • two with what looks like internal issues in testing: contoureR, kerpg
  • two which were lacking rgdal, and I usually skip those: mapview, stplanr
  • one of mine/ours which needs an update (also local testing issue): Rblpapi
  • one with a C++ build error against Modules -- which may be related to @romainfrancois recent change as I don't think we had other changes there lately: diversitree
  • one with an issue against RcppParallel: text2vec so I should talk to @kevinushey .

So I merge this now. We can probably clean the other two easily enough.

@eddelbuettel eddelbuettel merged commit 684fa32 into RcppCore:master Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C stack usage is too close to the limit when loading a Module
2 participants