Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #502 #503

Merged
merged 1 commit into from
Jul 12, 2016
Merged

Fix for #502 #503

merged 1 commit into from
Jul 12, 2016

Conversation

nathan-russell
Copy link
Contributor

As discussed in #502, use rcpp_long_long_type and rcpp_ulong_long_type in algorithm.h to avoid warnings when compiling with clang in pedantic mode.

@eddelbuettel
Copy link
Member

@dcdillon Any comment on this and/or #502? Should be smooth sailing...

@dcdillon
Copy link
Contributor

I would actually suggest commenting out all the long long stuff for now. It doesn't need to be there for now for algorithm to work

@eddelbuettel
Copy link
Member

I appears to work just fine with the patch by @nathan-russell -- same behaviour in rev.dep checks as the test late last week, ie zero new failures.

So I leaning towards a) keeping it and b) folding the PR in.

@dcdillon
Copy link
Contributor

Suits me. Basically if the long long code in ctype ever gets called by algorithm it will break somewhere else anyhow. It's just there for completeness.

Additionally the warning either points to an error in clang or in the Rcpp long long protection macro. We should figure out which and report it.

@dcdillon
Copy link
Contributor

I'd offer to do it but all I have is a 5 inch screen until the 23rd.

@eddelbuettel
Copy link
Member

This looks good and passed a full rev.dep for which I just committed the logs / results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants