Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of eye, ones, and zeros #569

Merged
merged 3 commits into from Oct 25, 2016

Conversation

@nathan-russell
Copy link
Contributor

commented Oct 24, 2016

Changes reflecting the post-merge discussion in #566.

@eddelbuettel

This comment has been minimized.

Copy link
Member

commented Oct 24, 2016

Kinda awesome to have PR when the rev.dep check run that called for it still has almost four hours to go!

@nathan-russell

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2016

That's a positive way of looking at it; the pessimist in me might say "my last PR was so disruptive this fix was needed ASAP".

@eddelbuettel eddelbuettel merged commit ef07a32 into RcppCore:master Oct 25, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.