Skip to content

Conversation

eddelbuettel
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 4, 2016

Current coverage is 59.76% (diff: 100%)

Merging #601 into master will increase coverage by 1.22%

@@             master       #601   diff @@
==========================================
  Files            76         74     -2   
  Lines          5075       4988    -87   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2971       2981    +10   
+ Misses         2104       2007    -97   
  Partials          0          0          

Powered by Codecov. Last update 0c3d0b1...5620275

@eddelbuettel
Copy link
Member Author

Anyone?

@thirdwing
Copy link
Member

I have to say this is something I know really little, but LGTM.

@eddelbuettel
Copy link
Member Author

I am not expert on the covr package either but slowly getting a feel for it via a few other (smaller!!) packages. It wraps very cleverly around calls to code and 'counts' -- for R by modifying the code, for compiled code via gcov. It helps some -- became aware of a regression on the weekend (in another and smaller package) where a line all of sudden was no longer covered when I changed code, and indeed, an argument was ignored when it should not have been...

@eddelbuettel
Copy link
Member Author

Also: if you use Chrome, the plugin is neat as you then see the code at GitHub itself "coloured" green and red depending on whether it has coverage or not.

@eddelbuettel
Copy link
Member Author

eddelbuettel commented Dec 6, 2016

No further complaints to will merge.

@eddelbuettel eddelbuettel merged commit fd0b205 into master Dec 6, 2016
@eddelbuettel eddelbuettel deleted the feature/more_tests branch December 6, 2016 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants