Use vector for dynamic memory in sample (closes #612) #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
approved these changes
Dec 14, 2016
| @@ -13,6 +13,7 @@ RnwWeave: Sweave | |||
| LaTeX: pdfLaTeX | |||
|
|
|||
| AutoAppendNewline: Yes | |||
| StripTrailingWhitespace: Yes | |||
| @@ -1,8 +1,13 @@ | |||
| 2016-12-13 Nathan Russell <russell.nr2012@gmail.com> | |||
| 2016-12-14 Nathan Russell <russell.nr2012@gmail.com> | |||
|
|
||
| // In order to mirror the behavior of `base::sample` | ||
| // as closely as possible, this file contains adaptations | ||
| #include <vector> |
There was a problem hiding this comment.
Code below looks good. I trust the tests...
Current coverage is 62.42% (diff: 100%)@@ master #616 diff @@
==========================================
Files 69 69
Lines 4798 4798
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2995 2995
Misses 1803 1803
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the use of
alloca,Calloc, andFreewithstd::vector.