two refinements for Date.cpp required on Windows #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 76.35% (diff: 100%)@@ master #623 diff @@
==========================================
Files 67 67
Lines 4017 4017
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 3067 3067
Misses 950 950
Partials 0 0
|
|
@kevinushey @nathan-russell @thirdwing @jjallaire : If you have a moment ... I had botched Windows builds, this restores it and is otherwise pretty minimal. |
nathan-russell
approved these changes
Jan 5, 2017
thirdwing
approved these changes
Jan 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need one change to compile (!!) on Windows, and on test (using six digits precision) fails.
Edit Turns out that was a TZ issue instead.