two refinements for Date.cpp required on Windows #623

Merged
merged 2 commits into from Jan 5, 2017

Projects

None yet

4 participants

@eddelbuettel
Member
eddelbuettel commented Jan 4, 2017 edited

We need one change to compile (!!) on Windows, and on test (using six digits precision) fails.

Edit Turns out that was a TZ issue instead.

eddelbuettel added some commits Jan 4, 2017
@eddelbuettel eddelbuettel two refinements for Date.cpp required on Windows
24bc301
@eddelbuettel eddelbuettel refined test.Datetime.formatting for Windoze
6410f43
@codecov-io
codecov-io commented Jan 4, 2017 edited

Current coverage is 76.35% (diff: 100%)

Merging #623 into master will not change coverage

@@             master       #623   diff @@
==========================================
  Files            67         67          
  Lines          4017       4017          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           3067       3067          
  Misses          950        950          
  Partials          0          0          

Powered by Codecov. Last update f0442a0...6410f43

@eddelbuettel
Member

@kevinushey @nathan-russell @thirdwing @jjallaire : If you have a moment ... I had botched Windows builds, this restores it and is otherwise pretty minimal.

@eddelbuettel eddelbuettel merged commit a53c4c5 into master Jan 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the bugfix/date_windows branch Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment