Skip to content

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Apr 13, 2017

for copy constructor, to avoid warning in -Wextra.

@codecov-io
Copy link

Codecov Report

Merging #670 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #670   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          65       65           
  Lines        3303     3303           
=======================================
  Hits         3069     3069           
  Misses        234      234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d8388...ec8c6ad. Read the comment docs.

@kevinushey
Copy link
Contributor

LGTM

@eddelbuettel
Copy link
Member

I turned a rev.dep on for a combination of #670 and #671 but it will run into the night.

@eddelbuettel
Copy link
Member

And given the very recent change to #671 I just updated to that and restarted.

@eddelbuettel eddelbuettel merged commit d4ec13f into RcppCore:master Apr 14, 2017
@eddelbuettel
Copy link
Member

Reverse-depends check worked just fine, so merging this.

@krlmlr krlmlr deleted the f-df-constructor branch July 8, 2017 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants