New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly call parent constructor #670

Merged
merged 1 commit into from Apr 14, 2017

Conversation

Projects
None yet
4 participants
@krlmlr
Contributor

krlmlr commented Apr 13, 2017

for copy constructor, to avoid warning in -Wextra.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Apr 13, 2017

Codecov Report

Merging #670 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #670   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          65       65           
  Lines        3303     3303           
=======================================
  Hits         3069     3069           
  Misses        234      234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d8388...ec8c6ad. Read the comment docs.

Codecov Report

Merging #670 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #670   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          65       65           
  Lines        3303     3303           
=======================================
  Hits         3069     3069           
  Misses        234      234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d8388...ec8c6ad. Read the comment docs.

@kevinushey

This comment has been minimized.

Show comment
Hide comment
@kevinushey

kevinushey Apr 13, 2017

Contributor

LGTM

Contributor

kevinushey commented Apr 13, 2017

LGTM

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Apr 13, 2017

Member

I turned a rev.dep on for a combination of #670 and #671 but it will run into the night.

Member

eddelbuettel commented Apr 13, 2017

I turned a rev.dep on for a combination of #670 and #671 but it will run into the night.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Apr 13, 2017

Member

And given the very recent change to #671 I just updated to that and restarted.

Member

eddelbuettel commented Apr 13, 2017

And given the very recent change to #671 I just updated to that and restarted.

@eddelbuettel eddelbuettel merged commit d4ec13f into RcppCore:master Apr 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Apr 14, 2017

Member

Reverse-depends check worked just fine, so merging this.

Member

eddelbuettel commented Apr 14, 2017

Reverse-depends check worked just fine, so merging this.

@krlmlr krlmlr deleted the krlmlr:f-df-constructor branch Jul 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment