Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native registration for exports with name attribute (fixes #702) #703

Merged
merged 1 commit into from
Jun 1, 2017

Conversation

jjallaire
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #703 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #703   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          66       66           
  Lines        3587     3587           
=======================================
  Hits         3212     3212           
  Misses        375      375
Impacted Files Coverage Δ
src/attributes.cpp 98.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4e9c5...a29c4e0. Read the comment docs.

@eddelbuettel
Copy link
Member

eddelbuettel commented Jun 1, 2017

Thanks for the quick PR. Will merge, and the possibly rearrange ChangeLog to re-establish chronological order...

@eddelbuettel eddelbuettel merged commit 2ab0ecd into master Jun 1, 2017
eddelbuettel added a commit that referenced this pull request Jun 1, 2017
@eddelbuettel eddelbuettel deleted the bugfix/rcpp-export-name-registration branch June 14, 2017 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants