Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit cast from size_t to int #715

Merged
merged 1 commit into from Jun 18, 2017
Merged

Explicit cast from size_t to int #715

merged 1 commit into from Jun 18, 2017

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Jun 17, 2017

to support -Wconversion.

@codecov-io
Copy link

Codecov Report

Merging #715 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files          66       66           
  Lines        3588     3588           
=======================================
  Hits         3214     3214           
  Misses        374      374

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec267a...cbfc8f2. Read the comment docs.

Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and nicely minimal too

@krlmlr
Copy link
Contributor Author

krlmlr commented Jun 17, 2017

Thanks. The other option is to store the data as R_xlen_t, which seems slightly more future-proof but does change the API of the class.

@eddelbuettel
Copy link
Member

I think dim is always an integer vector.

@eddelbuettel eddelbuettel merged commit 6691c5f into RcppCore:master Jun 18, 2017
@krlmlr krlmlr deleted the f-explicit-dim branch March 7, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants