Interface change: use R_xlen_t for loop unrolling #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
reviewed
Jul 8, 2017
eddelbuettel
approved these changes
Jul 8, 2017
|
Thanks for reviewing. Is it important to update the copyright year in the files? I have missed a few instances (also in the other PR). |
|
I do it when I remember it (which I usuallly do) but I am also not that religious about. You can add a commit, or we clean up another time... |
|
LGTM, although I would (very marginally) prefer to see us selecting |
kevinushey
approved these changes
Jul 8, 2017
|
Fair point. I guess a reverse depends check will give us some clues. |
thirdwing
approved these changes
Jul 8, 2017
|
Passed a full reverse-depends check with flying colour, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To compile RSQLite with
-Wconversion -Werror.