Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInterface change: use R_xlen_t for loop unrolling #731
Conversation
|
Looks good to me. Anybody else see issues? |
|
Thanks for reviewing. Is it important to update the copyright year in the files? I have missed a few instances (also in the other PR). |
|
I do it when I remember it (which I usuallly do) but I am also not that religious about. You can add a commit, or we clean up another time... |
|
LGTM, although I would (very marginally) prefer to see us selecting |
|
Fair point. I guess a reverse depends check will give us some clues. |
|
Passed a full reverse-depends check with flying colour, merging. |
To compile RSQLite with
-Wconversion -Werror.