New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallthrough comments #792

Merged
merged 1 commit into from Dec 21, 2017

Conversation

Projects
None yet
2 participants
@krlmlr
Contributor

krlmlr commented Dec 21, 2017

for nitpick mode of gcc 7. Do we need a NEWS entry?

@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Dec 21, 2017

My general rule is "if iit is a commit it may as well have a ChangeLog entry" and "if it is a PR it better have a NEWS entry" but I can just go over the last three PRs at once later...

@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Dec 21, 2017

And so writing a comment 'fall-through' pleases the compiler? Seriously? Am I missing what is happening here?

@krlmlr

This comment has been minimized.

Contributor

krlmlr commented Dec 21, 2017

No kidding: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/

I still forgot to update inst/NEWS, if you could take a look...

@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Dec 21, 2017

Just when you think you've seen it all ;-)

I'll try to draft something for news and changelog when I'm on a my short train ride.

@eddelbuettel eddelbuettel merged commit 4a47dcb into RcppCore:master Dec 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@krlmlr krlmlr deleted the krlmlr:f-fallthrough branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment