Skip to content

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Dec 21, 2017

for nitpick mode of gcc 7. Do we need a NEWS entry?

@eddelbuettel
Copy link
Member

My general rule is "if iit is a commit it may as well have a ChangeLog entry" and "if it is a PR it better have a NEWS entry" but I can just go over the last three PRs at once later...

@eddelbuettel
Copy link
Member

eddelbuettel commented Dec 21, 2017

And so writing a comment 'fall-through' pleases the compiler? Seriously? Am I missing what is happening here?

@krlmlr
Copy link
Contributor Author

krlmlr commented Dec 21, 2017

No kidding: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/

I still forgot to update inst/NEWS, if you could take a look...

@eddelbuettel
Copy link
Member

Just when you think you've seen it all ;-)

I'll try to draft something for news and changelog when I'm on a my short train ride.

@eddelbuettel eddelbuettel merged commit 4a47dcb into RcppCore:master Dec 21, 2017
@krlmlr krlmlr deleted the f-fallthrough branch March 7, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants