Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace back-quotes with straight-quotes in normal text #845

Merged
merged 1 commit into from Apr 17, 2018

Conversation

@rstub
Copy link
Contributor

commented Apr 17, 2018

  • back-quotes used as single opening quotes by TeX are not necessary since csquotes.sty is used to handle smart quotes
  • back-quotes can confuse the markdown parser (c.f. section '2.1 Package Creation')

BTW, the closing quote and the last letter of the phrase are awfully close. It might make sense from a typographic point of view to use \textsl{'...'}. If you are interested, I can add this to this PR.

* back-quotes used as single opening quotes by TeX are not necessary since csquotes.sty is used to handle smart quotes
* back-quotes can confuse the markdown parser (c.f. section '2.1 Package Creation')
@eddelbuettel

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

Thanks for catching the remaining backquotes. A leftover from latex source I guess. I'll have to think about / look at the quotes together with \textsl. There is a bit of redundancy there. Maybe do away with one of them?

@rstub

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2018

Using either quote or \textsl would make a lot of sense. There are already several places where only \textsl is used. For only quotes, I have found two references to 'Rcpp Attributes' in Rcpp-FAQ.Rmd.

@eddelbuettel eddelbuettel merged commit 462914a into RcppCore:master Apr 17, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@coatless

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2018

Down with \textsl{}!

In all reality, I think that is the only latex specific code still embedded in the vignettes. If it can be removed by typesetting using quotes, then that's an ideal way to go.

@eddelbuettel

This comment has been minimized.

Copy link
Member

commented Apr 17, 2018

Could do. I like \textsl{} better than \textit{} which markdown's _ gives us. The only thing i care about is the pdf output, though, and to me slanted looks best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.