Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making Environment::new_child() const #858

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
3 participants
@romainfrancois
Copy link
Contributor

romainfrancois commented Jun 1, 2018

so that we can call new_child() on a const Environment&.

I did not add a test because for some reason 🤷‍♀️ the existing test about new_child is commented out:

    #test.environment.child <- function(){
    #    checkEquals( parent.env(runit_child()), globalenv(), msg = "child environment" )
    #}
@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Jun 1, 2018

Let's have a look later (I have to rush to R/Finance) what git glame says about the commenting out of the test. There were cases were win-builder (or Slowlaris) would puke so ...

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 1, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@032d307). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #858   +/-   ##
=========================================
  Coverage          ?   90.49%           
=========================================
  Files             ?       70           
  Lines             ?     3240           
  Branches          ?        0           
=========================================
  Hits              ?     2932           
  Misses            ?      308           
  Partials          ?        0
Impacted Files Coverage Δ
inst/include/Rcpp/Environment.h 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 032d307...89cb334. Read the comment docs.

@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Jun 1, 2018

Looks like it was me on 2 Apr 2016 but I didn't leave a "why" in the ChangeLog. I will merge this now, get a rev.dep done just in case and we can look into the unit test issue separately. If you feel motivated to look into this, maybe you could try on win-builder or rhub?

@eddelbuettel eddelbuettel merged commit 6886a43 into RcppCore:master Jun 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.