evaluate call in base env (#861)

[kevinushey]

This is the simpler version of my prior patch for #861 (as recommended by @lionel-). If this builds cleanly I think it should be good to merge

[codecov-io]

Codecov Report

Merging #863 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #863   +/-   ##
======================================
  Coverage    90.3%   90.3%           
======================================
  Files          70      70           
  Lines        3261    3261           
======================================
  Hits         2945    2945           
  Misses        316     316

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d669e...bd54dbf. Read the comment docs.

[lionel-]

Thanks! It should also have no adverse effects on tracebacks, unlike the inlining solution.

[eddelbuettel]

Thanks. You're fire today :) Thanks for all that.

I guess I need to figure what I'll turn on to rev.dep. I guess I should start with Lionel's PR with the extra flag set.

[eddelbuettel]

Passes fine in full rev.dep (one level) so merging (after adjusing by hand here for merge conflicts).

[lionel-]

@eddelbuettel There was an issue with the merge conflict resolution, this PR only contains Changelog changes.

[eddelbuettel]

Boo.

Well, master is master. Either we all manage to produce clean PRs that actually change code, or we just paint the bike shed. Looks like this time we focused on the bikeshed.

[eddelbuettel]

@lionel- @kevinushey @thirdwing : As Lionel pointed out here, something went amiss with the PRs. I only ever resolved conflicts (on the website) pertaining to ChangeLog so I am not sure how this happens -- but between us we seem to have managed to loose some code. Any idea how to check what's missing, besides glancing at the PR reports here and master?

[kevinushey]

I should be able to fix things up on master.

[kevinushey]

2cb0d5e

[eddelbuettel]

Maybe I was blind (it was late when I came across @lionel- 's message) but I didn't even see the correct fragment in master. I guess I may been dense and been on another branch...

Thanks for the fix, @kevinushey.