Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate call in base env (#861) #863

Merged
merged 2 commits into from Jun 8, 2018

Conversation

Projects
None yet
4 participants
@kevinushey
Copy link
Contributor

kevinushey commented Jun 6, 2018

This is the simpler version of my prior patch for #861 (as recommended by @lionel-). If this builds cleanly I think it should be good to merge

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 6, 2018

Codecov Report

Merging #863 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #863   +/-   ##
======================================
  Coverage    90.3%   90.3%           
======================================
  Files          70      70           
  Lines        3261    3261           
======================================
  Hits         2945    2945           
  Misses        316     316

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d669e...bd54dbf. Read the comment docs.

@lionel-

This comment has been minimized.

Copy link
Contributor

lionel- commented Jun 6, 2018

Thanks! It should also have no adverse effects on tracebacks, unlike the inlining solution.

@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Jun 6, 2018

Thanks. You're fire today :) Thanks for all that.

I guess I need to figure what I'll turn on to rev.dep. I guess I should start with Lionel's PR with the extra flag set.

@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Jun 8, 2018

Passes fine in full rev.dep (one level) so merging (after adjusing by hand here for merge conflicts).

@eddelbuettel eddelbuettel merged commit e3c8558 into master Jun 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@lionel-

This comment has been minimized.

Copy link
Contributor

lionel- commented Jun 22, 2018

@eddelbuettel There was an issue with the merge conflict resolution, this PR only contains Changelog changes.

@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Jun 22, 2018

Boo.

Well, master is master. Either we all manage to produce clean PRs that actually change code, or we just paint the bike shed. Looks like this time we focused on the bikeshed.

@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Jun 22, 2018

@lionel- @kevinushey @thirdwing : As Lionel pointed out here, something went amiss with the PRs. I only ever resolved conflicts (on the website) pertaining to ChangeLog so I am not sure how this happens -- but between us we seem to have managed to loose some code. Any idea how to check what's missing, besides glancing at the PR reports here and master?

@kevinushey

This comment has been minimized.

Copy link
Contributor Author

kevinushey commented Jun 22, 2018

I should be able to fix things up on master.

@kevinushey

This comment has been minimized.

Copy link
Contributor Author

kevinushey commented Jun 22, 2018

@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Jun 22, 2018

Maybe I was blind (it was late when I came across @lionel- 's message) but I didn't even see the correct fragment in master. I guess I may been dense and been on another branch...

Thanks for the fix, @kevinushey.

@eddelbuettel eddelbuettel deleted the bugfix/rcpp-eval-base-env branch Jul 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.