Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when debugging, abort with error on cast when incompatible with STRSXP #882

Merged
merged 1 commit into from Jul 20, 2018

Conversation

Projects
None yet
3 participants
@jackwasey
Copy link
Contributor

jackwasey commented Jul 20, 2018

As with #860, if NDEBUG is unset, then abort on a failed cast to STRSXP. #860 missed this code path. (Although I think this is a benign, the current master 2d4eb21 doesn't pass its own tests, so I can't complete an R CMD check after this patch.)

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 20, 2018

Codecov Report

Merging #882 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #882   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files          71       71           
  Lines        3271     3271           
=======================================
  Hits         2947     2947           
  Misses        324      324
Impacted Files Coverage Δ
inst/include/Rcpp/r_cast.h 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d4eb21...6cf0bf3. Read the comment docs.

@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Jul 20, 2018

Thanks, that PR looks fine.

What do you mean by "the current master 2d4eb21 doesn't pass its own tests" ? It obviously works at Travis, as it does on my box. Can you detail what goes wrong at your end?

@eddelbuettel eddelbuettel merged commit e0f04a8 into RcppCore:master Jul 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jackwasey

This comment has been minimized.

Copy link
Contributor Author

jackwasey commented Jul 20, 2018

Thanks. BTW, I was unable to reproduce the RUnit test failures in a clean docker environment.

@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Jul 20, 2018

Thanks for the follow-up. Also have (as you may have seen) a pending PR for the min() and max() issue.

@jackwasey

This comment has been minimized.

Copy link
Contributor Author

jackwasey commented Jul 20, 2018

Yes, I spotted that: impressive speed, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.