when debugging, abort with error on cast when incompatible with STRSXP

[jackwasey]

As with #860, if NDEBUG is unset, then abort on a failed cast to STRSXP. #860 missed this code path. (Although I think this is a benign, the current master 2d4eb21 doesn't pass its own tests, so I can't complete an R CMD check after this patch.)

[codecov-io]

Codecov Report

Merging #882 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #882   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files          71       71           
  Lines        3271     3271           
=======================================
  Hits         2947     2947           
  Misses        324      324

Impacted Files	Coverage Δ
inst/include/Rcpp/r_cast.h	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d4eb21...6cf0bf3. Read the comment docs.

[eddelbuettel]

Thanks, that PR looks fine.

What do you mean by "the current master 2d4eb21 doesn't pass its own tests" ? It obviously works at Travis, as it does on my box. Can you detail what goes wrong at your end?

[jackwasey]

Thanks. BTW, I was unable to reproduce the RUnit test failures in a clean docker environment.

[eddelbuettel]

Thanks for the follow-up. Also have (as you may have seen) a pending PR for the min() and max() issue.

[jackwasey]

Yes, I spotted that: impressive speed, much appreciated.