New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deprecate ldflags #887

Merged
merged 2 commits into from Jul 28, 2018

Conversation

Projects
None yet
2 participants
@eddelbuettel
Member

eddelbuettel commented Jul 28, 2018

No description provided.

eddelbuettel added some commits Jul 28, 2018

deprecate LdFlags() and RcppLdFlags()
plus some non-exported variants
@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Jul 28, 2018

Member

Nothing too tricky here but a review or a thumbs up would still be appreciated.

Member

eddelbuettel commented Jul 28, 2018

Nothing too tricky here but a review or a thumbs up would still be appreciated.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Jul 28, 2018

Member

Thanks much, @kevinushey.

Member

eddelbuettel commented Jul 28, 2018

Thanks much, @kevinushey.

@eddelbuettel eddelbuettel merged commit c27f0cb into master Jul 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the feature/deprecate_ldflags branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment