Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix(no_init(,)) sets the nrows member #908

Merged
merged 3 commits into from
Oct 2, 2018
Merged

Matrix(no_init(,)) sets the nrows member #908

merged 3 commits into from
Oct 2, 2018

Conversation

romainfrancois
Copy link
Contributor

Discussed in #907

eddelbuettel
eddelbuettel approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll toss in a rev.dep check when I get home just in case.

@eddelbuettel
Copy link
Member

No new issues in rev.dep test (logs here) so merging.

Thanks!

@eddelbuettel eddelbuettel merged commit 30ff4a1 into RcppCore:master Oct 2, 2018
@eddelbuettel
Copy link
Member

And for completeness, marked as 0.12.19.2 and release to the RcppCore drat.

@romainfrancois romainfrancois deleted the bug/Matrix-no-init branch October 3, 2018 11:16
@romainfrancois romainfrancois mentioned this pull request Feb 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddelbuettel eddelbuettel eddelbuettel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romainfrancois @eddelbuettel