Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix(no_init(,)) sets the nrows member #908

Merged
merged 3 commits into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@romainfrancois
Copy link
Contributor

romainfrancois commented Oct 1, 2018

Discussed in #907

@eddelbuettel
Copy link
Member

eddelbuettel left a comment

Looks good to me. I'll toss in a rev.dep check when I get home just in case.

@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Oct 2, 2018

No new issues in rev.dep test (logs here) so merging.

Thanks!

@eddelbuettel eddelbuettel merged commit 30ff4a1 into RcppCore:master Oct 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Oct 2, 2018

And for completeness, marked as 0.12.19.2 and release to the RcppCore drat.

@romainfrancois romainfrancois deleted the romainfrancois:bug/Matrix-no-init branch Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.