Add new class StreambufSwitcher #918
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It redirects std::cout/cerr to Rstreambuf during its lifetime. As a trial, I inserted a code to construct an object in `RcppExports.cpp` for package developers. It works as expected, but std:cout is detected and complained by `R CMD check`. The definition of StreambufSwitcher may need to be move to somewhere outside the scope of the check. I also don't know how to apply this feature to non-package usage like `sourceCpp()`. Therefore, please take this PR as a starting point of discussion.
|
Thanks for filing this. Maybe an initial issue ticket would have been even better, but we have a starting point. This may not be the the final PR on this, but it gets the ball rolling. |
|
While this is reasonable, I don't think this will suffice for getting around CRAN checks because regardless R CMD check is still going to see the usages of The only 'real' way around these CRAN checks is to ensure that any supporting libraries used / compiled alongside the package just don't use |
|
The time has come close this for inactivity. As proposed, it can't work. No harm donw, and we're of course always open to new proposals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It redirects std::cout/cerr to Rstreambuf during its lifetime. As a trial, I inserted a code to construct an object in
RcppExports.cppfor package developers. It works as expected, butstd:coutis detected and complained byR CMD check. The definition ofStreambufSwitchermay need to be move to somewhere outside the scope of the check. I also don't know how to apply this feature to non-package usage likesourceCpp(). Therefore, please take this PR as a starting point of discussion.