Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/ filenames now consistently lowercased #956

merged 1 commit into from Mar 20, 2019


Copy link

commented Mar 20, 2019

This is entirely cosmetic: three remaining uppercase-named files in src/ are now lower-cased so that the compilation looks a little prettier:

[... also edited slightly below ...]
** libs
g++ -I[...]  -c api.cpp -o api.o         
g++ -I[...]  -c attributes.cpp -o attributes.o        
g++ -I[...]  -c barrier.cpp -o barrier.o  
g++ -I[...]  -c date.cpp -o date.o         
g++ -I[...]  -c module.cpp -o module.o        
g++ -I[...]  -c rcpp_init.cpp -o rcpp_init.o     
g++ -shared -o api.o attributes.o barrier.o date.o module.o rcpp_init.o \
    -L/usr/lib/R/lib -lR                                    
installing to /usr/local/lib/R/site-library/Rcpp/libs

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2019

@kevinushey @jjallaire if you have a split-second to glance at this I'd appreciate it.

Should be uncontroversional apart from the implicit bike-shedding for which I apologize 😃


This comment has been minimized.

Copy link

commented Mar 20, 2019


@eddelbuettel eddelbuettel merged commit fa1a111 into master Mar 20, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@eddelbuettel eddelbuettel deleted the feature/lowercase_src branch Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.