RcppArmadillo 15.2.2-0 with Armadillo 15.2.2 #498
Merged
+113
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades RcppArmadillo to version 15.2.2-0, incorporating Armadillo 15.2.2 with enhancements to random number generation for OpenMP and addressing macOS-specific LAPACK issues.
- Updated package version from 15.2.1-0 to 15.2.2-0
- Upgraded to Armadillo 15.2.2 with improved RNG reproducibility for OpenMP
- Added macOS test skip to handle complex algebra LAPACK issues
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| inst/tinytest/test_Rlapack.R | Adds early exit for macOS to skip complex algebra tests due to LAPACK incompatibility |
| inst/include/current/armadillo_bits/arma_version.hpp | Updates Armadillo patch version from 1 to 2 |
| inst/include/current/armadillo_bits/arma_rng.hpp | Implements thread-unique RNG seeding with OpenMP support for improved reproducibility |
| inst/NEWS.Rd | Documents the 15.2.2-0 release with changelog entries |
| configure.ac | Updates package version to 15.2.2-0 |
| configure | Regenerated configure script reflecting new version |
| DESCRIPTION | Updates package version and date |
| ChangeLog | Adds entries documenting the version update and changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains some reworking of the OpenMP detection on macOS. We made strides there is another branch so this will need some more work before going to CRAN so this upstream release will once again be GitHub-only for now.