allow ^0.14.7, tests pass #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mjackson any interest in this? |
mjackson
requested changes
Dec 9, 2016
Member
mjackson
left a comment
mjackson
left a comment
There was a problem hiding this comment.
Overall, this looks great. Thanks for the PR!
package.json
Outdated
| "react": "^15.3.0", | ||
| "react-dom": "^15.3.0", | ||
| "react": "^15.3.0 || ^0.14.7", | ||
| "react-dom": "^15.3.0 || ^0.14.7", |
Member
There was a problem hiding this comment.
Please omit the extra space on this line.
README.md
Outdated
|
|
||
| You can find the library on `window.ReactMedia`. | ||
|
|
||
| ## Test |
Member
There was a problem hiding this comment.
There's no need to include testing instructions in the README.
.gitignore
Outdated
| @@ -1 +1,2 @@ | |||
| umd | |||
| /node_modules/ | |||
Member
There was a problem hiding this comment.
Please don't change our .gitignore :)
Member
|
@rharriso Wanna finish this up? Or should we close? |
Contributor
Author
|
@mjackson oh sorry, this got buried in my notifications. |
prioritize 15.x pull feedback
Contributor
Author
|
@mjackson updated from your feedback |
Member
|
Thanks @rharriso! :D |
Member
|
Released in version 1.4.0 |
Contributor
Author
|
@mjackson thanks! Also, I just realized I met your partner @ryanflorence at a training session last week. It was really enjoyable! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reran the tests using
0.14.7(adjusted the dev dependencies) all passed.