-
Notifications
You must be signed in to change notification settings - Fork 433
Update Framework Overview for RAC 5.0 #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Framework Overview for RAC 5.0 #109
Conversation
Documentation/FrameworkOverview.md
Outdated
| ## Signals | ||
|
|
||
| A **signal**, represented by the [`Signal`][Signal] type, is any series of [events](#events) | ||
| A **signal**, represented by the [`SignalProtocol`][Signal] protocol, is any series of [events](#events) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be changed. We use SignalProtocol only to constraint the extensions, since we can't use same-type requirements in concrete type extensions yet. A signal is always the concrete type Signal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright ✅
Documentation/FrameworkOverview.md
Outdated
| ## Signal Producers | ||
|
|
||
| A **signal producer**, represented by the [`SignalProducer`][SignalProducer] type, creates | ||
| A **signal producer**, represented by the [`SignalProducerProtocol`][SignalProducer] protocol, creates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Documentation/FrameworkOverview.md
Outdated
| An **observer** is anything that is waiting or capable of waiting for [events](#events) | ||
| from a [signal](#signals). Within RAC, an observer is represented as | ||
| an [`Observer`][Observer] that accepts [`Event`][Event] values. | ||
| from a [signal](#signals). Within RAC, an observer is represented by the [`ObserverProtocol`][Observer]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Documentation/FrameworkOverview.md
Outdated
| ## Actions | ||
|
|
||
| An **action**, represented by the [`Action`][Action] type, will do some work when | ||
| An **action**, represented by the [`ActionProtocol`][Action] protocol, will do some work when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
d0b1de4 to
78364e5
Compare
|
@andersio So, for |
|
Hmm, probably not |
78364e5 to
b192a17
Compare
|
Alright, I've change that for |
|
|
||
| ## Properties | ||
|
|
||
| A **property**, represented by the [`PropertyProtocol`][Property], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 132 has a broken link. May you help fix it please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my, missed that in #101, but fixed it now 👍
bb5ab22 to
520366c
Compare
As the title says.
Most is about the renaming of the events (
Next->value, lowercases) and the use of the Protocols rather than the types. Furthermore,SignalProducer.bufferis now gone.Similar to the part about
DynamicPropertywhich was deleted in #101 because its now in ReactiveCocoa, I've also deleted the part aboutCocoaAction.