Skip to content

Update DebuggingTechniques for ReactiveSwift 1.0 #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2016
Merged

Update DebuggingTechniques for ReactiveSwift 1.0 #114

merged 1 commit into from
Nov 27, 2016

Conversation

@iv-mexx
Copy link
Contributor

@iv-mexx iv-mexx commented Nov 24, 2016

  • Name changes due to Swift 3.0 / ReactiveSwift 1.0
  • Compiler Error has changed (I was just looking if that still confuses the compiler as of Xcode 8.1, and it still does)
  • Removed DynamicProperty since its now in ReactiveCocoa
  • Changed example with UILabel.rac_text to use a MutableProperty<String> instead.
  • Fixed a broken link

andersio
andersio approved these changes Nov 24, 2016
View reviewed changes
Documentation/DebuggingTechniques.md Outdated
...
let searchString = property.producer
.throttle(0.5, on: QueueScheduler.main)
.logEvents(events:[.disposed]) // This will happen when `property` is released
Copy link
Member

@andersio andersio Nov 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after colon.

Copy link
Contributor Author

@iv-mexx iv-mexx Nov 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@iv-mexx iv-mexx force-pushed the feature/debuggingTechniques branch from 0e3cbda to 71fabac Compare November 24, 2016 22:15
@andersio andersio merged commit b540e78 into ReactiveCocoa:master Nov 27, 2016
@iv-mexx iv-mexx deleted the feature/debuggingTechniques branch November 29, 2016 08:41
@iv-mexx iv-mexx mentioned this pull request Dec 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdiep mdiep mdiep approved these changes

@andersio andersio andersio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iv-mexx @mdiep @andersio