Make Action retain its state property.
#155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
force-pushed
the
action-retaining
branch
from
b940ca0 to
6be0287
Compare
sharplet
requested changes
Dec 15, 2016
Contributor
sharplet
left a comment
sharplet
left a comment
There was a problem hiding this comment.
Mind adding a test for this?
mdiep
approved these changes
Dec 15, 2016
sharplet
reviewed
Dec 15, 2016
| var property: MutableProperty<Bool>? = MutableProperty(false) | ||
| weak var weakProperty = property | ||
|
|
||
| var action: Action<(), (), NoError>? = Action(state: property!, enabledIf: { _ in true }) { _ in |
Contributor
There was a problem hiding this comment.
This line is triggering a "variable is written to but never read" warning. Mind changing this to a let constant? Probably doesn't need to be optional either.
Member
Author
There was a problem hiding this comment.
It is part of the test case. action is set to nil below to test if the property is really retained by the Action.
sharplet
approved these changes
Dec 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142