Skip to content

Conversation

@ikesyo
Copy link
Member

@ikesyo ikesyo commented Jul 26, 2017

See Carthage/Carthage#2077 (comment) and Carthage/Carthage#2077 (comment).

Checklist

  • [ ] Updated CHANGELOG.md.

@mdiep
Copy link
Contributor

mdiep commented Jul 26, 2017

I don't understand what this adds. Could you elaborate? It seems like this would just increase conflicts and require more type annotations.

@ikesyo ikesyo force-pushed the init-overloads-for-noerror branch from a8a1422 to a2b4db1 Compare July 26, 2017 17:19
@ikesyo
Copy link
Member Author

ikesyo commented Jul 26, 2017

To disambiguate something like this:

let producer1 = SignalProducer(value: "")
	.flatMap(.concat) { str -> SignalProducer<Int, AnyError> in .empty }

let producer2 = SignalProducer(["", ""])
	.flatMap(.concat) { str -> SignalProducer<Int, AnyError> in .empty }

@ikesyo ikesyo force-pushed the init-overloads-for-noerror branch from 8c54f92 to cc4ef96 Compare July 27, 2017 17:16
@ikesyo ikesyo requested review from andersio and mdiep July 29, 2017 06:59
Copy link
Member

@andersio andersio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a QoL improvement too, since constant producer now gets NoError inferred by default.

@mdiep
Copy link
Contributor

mdiep commented Aug 1, 2017

This breaks source compatibility, but maintains binary compatibility, correct?

@andersio
Copy link
Member

andersio commented Aug 1, 2017

I am not convinced that it is source breaking.

@andersio andersio merged commit 7bc128a into master Aug 11, 2017
@andersio andersio deleted the init-overloads-for-noerror branch August 11, 2017 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants