fix(QueueScheduler): reset active flag when action throws

[kwonoj]

Description:

This PR amends flush behavior in QueueScheduler, reset active status even if queued action throws, so further queued action can be executed.

Related issue (if exists):

closes #1464

• Little bit unsure if this change's legit, or might be better recommended way. Will wait for comment.

[trxcllnt]

LGTM

[ccrowhurstram]

It's seems this is relatively core / basic functionality. Therefore, surprised that the existing tests didn't pick this up.

Shouldn't there be a test to add? That would aid as a reminder that this kind of stuff needs testing?

[kwonoj]

@ccrowhurstram I also noticed there isn't test coverage for QueueScheduler, started to working on those. I definitely agree test coverage should cover most of core features.

[ccrowhurstram]

Excellent

[kwonoj]

Closing this by #1469 .

[benlesh]

Whoa, whoa, hold on... did we perf test this? This is going to deoptimize the flush function. I have two other PRs proposing other changes around this.

[kwonoj]

@Blesh , this PR isn't merged, after your PR propsed. it's simply closed.

[benlesh]

I see.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.