RxKotlin 2.0 Release Candidate #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code review related fixes.
flowable extensions added minor fixes
* Subjects removed * Operators added
# Conflicts: # build.gradle # gradle/wrapper/gradle-wrapper.properties # src/main/kotlin/rx/lang/kotlin/subscribers.kt # src/main/kotlin/rx/lang/kotlin/subscription.kt # src/test/kotlin/rx/lang/kotlin/ExtensionTests.kt
Collaborator
Author
|
I think we should move package convention from We can do that last after we review and merge. |
Closed
Collaborator
Author
|
I'll figure out why tests are failing as well... |
Collaborator
Author
|
Okay, fixed all test issues. Feel free to take a look at this branch. After that, I will move to the new package convention, archive the old 2.x under "2.x-old", and create a new "2x". The package rename will make the conflicts not worthwhile to address, and therefore no good reason to merge. |
Collaborator
|
Thanks, @thomasnield looks good. I'll go through 1.0 and 2.0 RC once more to double check if anything is missed from the RC's. Closed #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @stepango,
I took your 2.x fork, made some changes to reflect what we did with 1.x, and pushed it as branch
2.x-devon the main repository.I swept to make sure that all
FlowableandObservablevariants were created, and remove any API that was removed in 1.x.I'll review again tomorrow to make sure nothing was missed, but this may be a good place to start considering a release candidate for 2.x. Let me know what you think.