update to netty 4.1.4.Final #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a regression in netty 4.1.3.Final, see: http://netty.io/news/2016/07/27/4-0-40-Final-4-1-4-Final.html The 4.1.4.Final version also includes a change to QueryStringDecoder that broke some of the UriInfoHolder tests. In particular the path is now decoded. I opted to change the tests to match the netty behavior. For context the netty ticket is: netty/netty#5590
|
Thanks @brharrington ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a regression in netty 4.1.3.Final, see:
http://netty.io/news/2016/07/27/4-0-40-Final-4-1-4-Final.html
The 4.1.4.Final version also includes a change to
QueryStringDecoder that broke some of the UriInfoHolder
tests. In particular the path is now decoded. I opted
to change the tests to match the netty behavior. For
context the netty ticket is: netty/netty#5590
Tests were successful locally after those changes.