Skip to content

Make SSE content type check tolerant of charset #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2016
Merged

Make SSE content type check tolerant of charset #557

merged 1 commit into from
Sep 12, 2016

Conversation

@rhart
Copy link
Contributor

@rhart rhart commented Sep 12, 2016

Fixes #552

@rhart
Copy link
Contributor Author

rhart commented Sep 12, 2016

There wasn't an obvious place to add a test for this. AFAICT there aren't any existing tests for unexpected content types and it's not overridable when using the http client as the sse encoder overrides whatever you set.

@NiteshKant NiteshKant added this to the 0.5.2-rc.5 milestone Sep 12, 2016
@NiteshKant
Copy link
Member

Thanks @rhart!
Yeah adding a test will need more changes to HttpServerResponse.

@NiteshKant NiteshKant merged commit 817aeee into ReactiveX:0.5.x Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.5.2-rc.5

Development

Successfully merging this pull request may close these issues.

2 participants

@rhart @NiteshKant