Make SSE content type check tolerant of charset #557

Merged
merged 1 commit into from Sep 12, 2016

Conversation

Projects
None yet
2 participants
@rhart
Contributor

rhart commented Sep 12, 2016

Fixes #552

@rhart

This comment has been minimized.

Show comment
Hide comment
@rhart

rhart Sep 12, 2016

Contributor

There wasn't an obvious place to add a test for this. AFAICT there aren't any existing tests for unexpected content types and it's not overridable when using the http client as the sse encoder overrides whatever you set.

Contributor

rhart commented Sep 12, 2016

There wasn't an obvious place to add a test for this. AFAICT there aren't any existing tests for unexpected content types and it's not overridable when using the http client as the sse encoder overrides whatever you set.

@NiteshKant NiteshKant added this to the 0.5.2-rc.5 milestone Sep 12, 2016

@NiteshKant

This comment has been minimized.

Show comment
Hide comment
@NiteshKant

NiteshKant Sep 12, 2016

Member

Thanks @rhart!
Yeah adding a test will need more changes to HttpServerResponse.

Member

NiteshKant commented Sep 12, 2016

Thanks @rhart!
Yeah adding a test will need more changes to HttpServerResponse.

@NiteshKant NiteshKant merged commit 817aeee into ReactiveX:0.5.x Sep 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment