Skip to content

Conversation

@tokuhirom
Copy link

RxNetty should escape HTML escape characters in default error response generator.
Current implementation may cause XSS( https://www.owasp.org/index.php/Cross-site_Scripting_(XSS) ).

If a user put a request path, query string, or any other string from client's request, it cause security vulnerability.

Copy link
Member

@NiteshKant NiteshKant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tokuhirom for the change!

@NiteshKant NiteshKant added this to the 0.4.20 milestone Nov 10, 2016
@NiteshKant NiteshKant added the bug label Nov 10, 2016
@NiteshKant NiteshKant merged commit 310a046 into ReactiveX:0.4.x Nov 10, 2016
@tokuhirom tokuhirom deleted the default-error-response-generator-html-escape branch November 11, 2016 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants