Skip to content
This repository was archived by the owner on Oct 1, 2018. It is now read-only.

Conversation

@zualexander
Copy link
Contributor

@zualexander zualexander commented Oct 27, 2017

closes #89

@codecov-io
Copy link

codecov-io commented Oct 27, 2017

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files           7        7           
  Lines          78       78           
  Branches        7        7           
=======================================
  Hits           69       69           
  Misses          6        6           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6920eb6...b2741a7. Read the comment docs.

@sumitarora
Copy link
Collaborator

@zualexander Could you please change the commit message to be docs instead of feat

@zualexander zualexander force-pushed the feature/89-operator-debounceTime branch from 1ef0c2f to 2595bf2 Compare October 27, 2017 14:50
@zualexander zualexander changed the title feat(89): brings content for documentation of debounceTime-operator docs(89): brings content for documentation of debounceTime-operator Oct 27, 2017
@kwonoj
Copy link
Member

kwonoj commented Oct 27, 2017

what's 89 means in scope?

@@ -1,6 +1,79 @@
import { OperatorDoc } from '../operator.model';
import { OperatorDoc } from "../operator.model";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we need declare war set lint rules between single quote to double quote.

@ladyleet
Copy link
Member

Thx @zualexander for this PR! :)

@sumitarora
Copy link
Collaborator

@zualexander Please rebase with master.

@zualexander zualexander force-pushed the feature/89-operator-debounceTime branch from 2595bf2 to 17315b7 Compare October 28, 2017 14:43
@zualexander
Copy link
Contributor Author

@sumitarora done

Copy link
Collaborator

@btroncone btroncone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Just a few small tweaks. 👍

attribute: "mandatory",
description: `The timeout duration in milliseconds
(or the time unit determined internally by the optional scheduler for the window of time required to
wait for emission silence before emitting the most recent source value.`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think parens need to be closed here.

shortDescription: {
description: `
Emits a value from the source Observable only after a particular time span has passed without another source emission.
It's like <a href="href="/operators#delay">delay</a>, but passes only the most recent value from each burst of emissions.`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stylistically, lets add class="markdown-code" to any code links.

@zualexander zualexander force-pushed the feature/89-operator-debounceTime branch from 957cb9f to 423b35a Compare October 30, 2017 18:27
@ashwin-sureshkumar ashwin-sureshkumar merged commit aa9f74f into ReactiveX:master Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add docs for operator : filtering - debounceTime

7 participants