-
Notifications
You must be signed in to change notification settings - Fork 61
docs(89): brings content for documentation of debounceTime-operator #138
docs(89): brings content for documentation of debounceTime-operator #138
Conversation
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
=======================================
Coverage 88.46% 88.46%
=======================================
Files 7 7
Lines 78 78
Branches 7 7
=======================================
Hits 69 69
Misses 6 6
Partials 3 3Continue to review full report at Codecov.
|
|
@zualexander Could you please change the commit message to be |
1ef0c2f to
2595bf2
Compare
|
what's 89 means in scope? |
| @@ -1,6 +1,79 @@ | |||
| import { OperatorDoc } from '../operator.model'; | |||
| import { OperatorDoc } from "../operator.model"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think we need declare war set lint rules between single quote to double quote.
|
Thx @zualexander for this PR! :) |
|
@zualexander Please rebase with master. |
2595bf2 to
17315b7
Compare
|
@sumitarora done |
btroncone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Just a few small tweaks. 👍
| attribute: "mandatory", | ||
| description: `The timeout duration in milliseconds | ||
| (or the time unit determined internally by the optional scheduler for the window of time required to | ||
| wait for emission silence before emitting the most recent source value.` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think parens need to be closed here.
| shortDescription: { | ||
| description: ` | ||
| Emits a value from the source Observable only after a particular time span has passed without another source emission. | ||
| It's like <a href="href="/operators#delay">delay</a>, but passes only the most recent value from each burst of emissions.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stylistically, lets add class="markdown-code" to any code links.
…class to link-tag
957cb9f to
423b35a
Compare
closes #89