This repository was archived by the owner on Oct 1, 2018. It is now read-only.
Sidenav design #16
Merged
Sidenav design #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@feloy this is really helpful thank you so much for doing that! 👍 merged. |
btroncone
reviewed
Oct 3, 2017
| @@ -1,10 +1,37 @@ | |||
| import { Component } from '@angular/core'; | |||
|
|
|||
| class Menu { | |||
Collaborator
There was a problem hiding this comment.
Could we update this to an interface?
btroncone
reviewed
Oct 3, 2017
| @@ -1,37 +1,24 @@ | |||
| <md-sidenav-container fullscreen> | |||
| <div class="app-fullpage"> | |||
| <md-toolbar color="accent" class="mat-elevation-z6"> | |||
Collaborator
Contributor
Author
There was a problem hiding this comment.
I'll look how to do this. Previous solution wasn't perfect because sidenav was on top of toolbar.
It seems that "md-sidenav-container fullscreen" is not usable with a toolbar
Contributor
Author
There was a problem hiding this comment.
In fact the toolbar is already sticky, isn't it? At least on Chrome and Firefox on Linux
Collaborator
There was a problem hiding this comment.
Apologies, just tested again and it looks great! 👍
Member
|
@btroncone I don't see why not! @feloy? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here a proposition for the sidenav design