This repository was archived by the owner on Oct 1, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
Separate operators in multiple pages #161
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
f560418
refactor(operators): Separate operators in multiple pages
feloy 5b3ad9b
refactor(operators): Adapt links for operators in different pages
feloy 6e41260
fix(operators): Show active menu entry
feloy 802953f
fix(operators): Redirect for not found operator
feloy 8c9fef3
feat(search): Add title and meta description to pages
feloy 2305d9d
fix(tests): Add SeoService provider for OperatorsComponent tests
feloy a78587c
Merge remote-tracking branch 'origin/master' into multipages
feloy e725a59
fix(rxjs): Use lettable operators
feloy 3774515
fix(operators): Remove unused subscription
feloy ac8a90e
fix(operators): Debug lettable operators and remove dead code
feloy 0cf78b3
fix(seo): Set SEO data in route config
feloy 7842697
fix(seo): Add a type for SEO data
feloy 4f49c3f
fix(operator): Compute a map of operators
feloy 5a231bb
fix(operators): Use Map for operators map
feloy c66aadf
refactor(operators): Separate operators in multiple pages
feloy e01b233
refactor(operators): Adapt links for operators in different pages
feloy b4c3d7c
fix(operators): Show active menu entry
feloy 23930c8
fix(operators): Redirect for not found operator
feloy e970438
feat(search): Add title and meta description to pages
feloy f25e238
fix(tests): Add SeoService provider for OperatorsComponent tests
feloy c64a5cc
fix(rxjs): Use lettable operators
feloy f7d2dc3
fix(operators): Remove unused subscription
feloy 267457e
fix(operators): Debug lettable operators and remove dead code
feloy 4130dcd
fix(seo): Set SEO data in route config
feloy 2d369a9
fix(seo): Add a type for SEO data
feloy a7f4182
fix(operator): Compute a map of operators
feloy 29198f5
fix(operators): Use Map for operators map
feloy 8a2386f
Merge branch 'multipages' of https://github.com/feloy/rxjs-docs into …
feloy f2b3ee8
Merge remote-tracking branch 'upstream/master' into multipages
feloy 2dd4ab7
Merge branch 'master' into multipages
sumitarora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,10 @@ | ||
| import { Component, OnInit } from "@angular/core"; | ||
| import { Component } from '@angular/core'; | ||
|
|
||
| @Component({ | ||
| selector: "app-companies", | ||
| templateUrl: "./companies.component.html", | ||
| styleUrls: ["./companies.component.scss"] | ||
| selector: 'app-companies', | ||
| templateUrl: './companies.component.html', | ||
| styleUrls: ['./companies.component.scss'] | ||
| }) | ||
| export class CompaniesComponent implements OnInit { | ||
| export class CompaniesComponent { | ||
| constructor() {} | ||
|
|
||
| ngOnInit() {} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/app/operators/components/related-operators/related-operators.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| <h2 class="related-operators"> Related Operators </h2> | ||
| <ul class="section-list"> | ||
| <li *ngFor="let related of relatedOperators"> | ||
| <a [href]="'/operators#' + related"> {{ related }} </a> | ||
| <a [routerLink]="['/operators', related]"> {{ related }} </a> | ||
| </li> | ||
| </ul> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is an Angular project I believe it's worth sticking to their official style guide that discourages from prefixing private variables with
_. See https://angular.io/guide/styleguide#style-03-04Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is debatable, in the material docs project
_is being used for private. I prefer this convention.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to stick to the existing code in the project and use _