Skip to content
This repository was archived by the owner on Oct 1, 2018. It is now read-only.

Conversation

@mustafamg
Copy link
Contributor

Closes #123

@codecov-io
Copy link

codecov-io commented Dec 1, 2017

Codecov Report

Merging #174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   74.49%   74.49%           
=======================================
  Files          10       10           
  Lines         149      149           
  Branches        7        7           
=======================================
  Hits          111      111           
  Misses         38       38
Impacted Files Coverage Δ
src/app/material/material.module.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5059b48...60dac02. Read the comment docs.

@ladyleet
Copy link
Member

ladyleet commented Dec 1, 2017

thx @mustafamg !

{
name: 'Rerun an interval Observable on every click even',
code: `
var clicks = Rx.Observable.fromEvent(document, 'click');
Copy link
Collaborator

@ashwin-sureshkumar ashwin-sureshkumar Dec 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mustafamg please use const to maintain consistency of an incoming PR from @btroncone

@ladyleet
Copy link
Member

ladyleet commented Dec 3, 2017

thx for this @mustafamg !

@ashwin-sureshkumar
Copy link
Collaborator

@mustafamg Thank you. Could you please update the commit message to follow guidelines.

docs(operators): add documentation for operator switchmap

Please rebase as well.

@mustafamg
Copy link
Contributor Author

mustafamg commented Dec 3, 2017

I am not expert with git stuff, @ashwin-sureshkumar Would you please advice how to rebase?
Edit: Ignore that, I think I got it.

@mustafamg mustafamg closed this Dec 3, 2017
@mustafamg mustafamg deleted the doc-switchmap branch December 3, 2017 22:47
@mustafamg mustafamg restored the doc-switchmap branch December 3, 2017 22:47
@mustafamg mustafamg reopened this Dec 3, 2017
@ashwin-sureshkumar
Copy link
Collaborator

@mustafamg - Just incase for your reference. Please follow below steps, I am being very explicit ignore if you have already done lot of these.

git remote -v

The above should two remote addresses

origin	git@github.com:mustafamg/rxjs-docs.git (fetch)
origin	git@github.com:mustafamg/rxjs-docs.git (push)
upstream	git@github.com:ReactiveX/rxjs-docs.git (fetch)
upstream	git@github.com:ReactiveX/rxjs-docs.git (push)

If you have only origin then please perform the below step

git remote add upstream git@github.com:ReactiveX/rxjs-docs.git

Then perform below steps

git checkout master 
git pull --ff upstream master
git checkout doc-switchmap
git rebase master -i 
/// To fix the commit message and update your commit message according to guidelines
git commit --amend 
git push -f

@mustafamg mustafamg changed the title Doc (Operator): switchmap docs (Operator): add documentation for operator switchMap Dec 4, 2017
@mustafamg
Copy link
Contributor Author

Many thanks, @ashwin-sureshkumar for the reply, it helped me do it. Thanks :)

@mustafamg
Copy link
Contributor Author

Any advice how to amend old commits' messages. Should I use rebase + reword for the commits?

@ashwin-sureshkumar ashwin-sureshkumar merged commit ffaac4f into ReactiveX:master Jan 7, 2018
@ladyleet
Copy link
Member

ladyleet commented Jan 8, 2018

thanks so much @ashwin-sureshkumar for this! @mustafamg sorry it took a second! holidays!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants