-
Notifications
You must be signed in to change notification settings - Fork 61
Added alt text to two images #197
Conversation
Added alternative text to the GitHub logo in the header. n/a
Added alternative text to the combineAll image. n/a
|
@chrisdemars woohoo your first PR here! congrats! |
|
Stoked to get the first one in @ladyleet! 🔥 |
|
@chrisdemars small little conflicts with your branch - can you resolve? |
|
Sure @ladyleet |
|
I actually don't know which version is the correct one @ladyleet 🙁 |
|
With help from @knittingcodemonkey, I think the merge is fixed. |
|
great! need one more reviewer and someone to push! :) i've already approved. |
knitcodemonkey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update seems to have resolved the merge conflict
| [src]="url" | ||
| *ngIf="url" /> | ||
| *ngIf="url" | ||
| alt="Diagram of how combineAll works" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to make a small update so combineAll isn't hardcoded, something like:
alt="Diagram of how {{operatorName}} works"
Or we can add a getter to this component for the alt text:
get altText() {
return `Diagram of how ${this.operatorName} works`;
}then:
[alt]="altText"
Thanks a ton for your help!
…mage. Added JS to generate the alt text for the combineAll image. n/a
|
I believe I made the change that @btroncone suggested. |
btroncone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! lgtm 👍
|
I think this might be ready to be merged? Possibly? |
|
Ready to merge this but looks like TravisCI is blocking? |
…chrisdemars-img-alt
…rxjs-docs into chrisdemars-img-alt
|
Admin squash and merge because Travis was not reporting back at all and didn't appear to know about the build even. |
|
Thanks @benlesh and @knittingcodemonkey |
|
Thank YOU! |
|
@chrisdemars srsly thank you so much for contributing! glad we finally got this in. :) and thank you @benlesh! |
I added alternative text to the GitHub logo in the header and the
combineAllgraphic in the operators section.