Skip to content
This repository was archived by the owner on Oct 1, 2018. It is now read-only.

Conversation

@btroncone
Copy link
Collaborator

Closes #200

@ladyleet
Copy link
Member

LGTM! Yay // @knittingcodemonkey

@knitcodemonkey
Copy link
Contributor

Thank you, @btroncone. It would have taken me a lot longer to get to this solution.

@codecov-io
Copy link

Codecov Report

Merging #206 into master will decrease coverage by 0.29%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #206     +/-   ##
=========================================
- Coverage   74.78%   74.49%   -0.3%     
=========================================
  Files           9       10      +1     
  Lines         119      149     +30     
  Branches        6        7      +1     
=========================================
+ Hits           89      111     +22     
- Misses         30       38      +8
Impacted Files Coverage Δ
src/app/core/core.module.ts 100% <100%> (ø) ⬆️
src/app/app.component.ts 57.69% <66.66%> (+0.54%) ⬆️
src/app/core/services/operator-menu.service.ts 72.72% <72.72%> (ø)
src/app/operators/operators.component.ts 92.5% <78.57%> (-7.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883ef9c...908c211. Read the comment docs.

@sumitarora sumitarora merged commit 512689e into ReactiveX:master Dec 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants