This repository was archived by the owner on Oct 1, 2018. It is now read-only.
fix(a11y): Add value to menu button #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add value to menu button to comply with buttons not having readable text. Add package-lock.json to gitignore. no breaking changes
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
=======================================
Coverage 74.49% 74.49%
=======================================
Files 10 10
Lines 149 149
Branches 7 7
=======================================
Hits 111 111
Misses 38 38Continue to review full report at Codecov.
|
guilhermejcgois
approved these changes
Dec 20, 2017
ashwin-sureshkumar
approved these changes
Dec 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add value to menu button to comply with buttons not having readable text. Add package-lock.json to gitignore
no breaking changes