This repository was archived by the owner on Oct 1, 2018. It is now read-only.
updated all components to lazy loaded #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed md to mat for icon-button re ran all tests and passed locally added extra line to spec for lint grabbed changes from #26 Update angular material prefix to mat and lock down package versions - Updated imports and component prefixes for angular material - Updated package.json to lock down versions - Added .npmrc config to save-exact Close #25
Contributor
Author
|
Apologies for all the noise on this pull request. Still getting used to git, I spend all my days in TFS |
Member
|
@kwonoj can you review this? this okay? maybe another set of angular eyes would help... @btroncone? |
Member
|
LGTM, once I got second eye from @btroncone will check this in. |
Collaborator
|
Looks good, could you set a preloading strategy to |
kwonoj
approved these changes
Oct 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated route module and creating feature modules and routes. Also had to update the material files and tags to get the application to run based on version bump. #27