feat(NGUI-175): Image component #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM! |
Hrithik-Gavankar
approved these changes
Oct 1, 2025
velias
reviewed
Oct 2, 2025
added 2 commits
October 2, 2025 21:24
Collaborator
|
Looks good to me, but I'm not FE / React expert. Can anyone look at it please ? @bennypowers @eyevana @grantsydney |
Collaborator
|
PR looks good to me. One suggestion I have is to use React sate to handle the image error instead of directly manipulating the DOM. For example, const [error, setError] = useState(false) and the conditionally render the error message. This avoids React potentially overwriting manual DOM changes on re-render |
Collaborator
Author
|
Hey @grantsydney I finished pushing the requested changes. Please review. |
added 2 commits
October 7, 2025 11:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.