-
Notifications
You must be signed in to change notification settings - Fork 3
feat(NGUI-176): Video component #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please document video-player abilities in README.md as discussed in RedHat-UX/next-gen-ui-agent#177 . |
|
BTW that AI generated PR description is too long/hard to read and understand ;-) Contains lots of unnecessary or duplicate or unrelated info. Try to keep it short and with important info only to make reviewer work easier :-D |
|
@grantsydney @eyevana can you review this PR also please as a FE/React experts |
velias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are all that e2e changes part of this PR? They should not be here
|
Hi @velias, Those e2e files were present when I initially cut the branch from main, which is why they appeared in this PR. Thank you for pointing it out! |
velias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Video Component Implementation
What's Changed:
VideoPlayerWrapperReact component with YouTube and direct video supportKey Features:
Testing:
Usage:
{ "component": "video-player", "video": "https://www.youtube.com/embed/v-PjgYDrg70", "video_img": "https://img.youtube.com/vi/v-PjgYDrg70/maxresdefault.jpg", "title": "Toy Story Trailer" }