Skip to content

Conversation

@Hrithik-Gavankar
Copy link
Collaborator

@Hrithik-Gavankar Hrithik-Gavankar commented Oct 1, 2025

Screenshot 2025-09-08 at 2 12 29 PM

Video Component Implementation

What's Changed:

  • Added VideoPlayerWrapper React component with YouTube and direct video support
  • Fixed backend data transformation to properly extract video URLs and poster images
  • Added error handling to prevent server crashes

Key Features:

  • YouTube video embedding with thumbnails
  • Direct video file playback
  • Poster image fallbacks
  • Responsive 16:9 aspect ratio

Testing:

  • 23/23 unit tests passing
  • Server stability improved (no more random crashes)
  • Video playback verified with test data

Usage:

{
  "component": "video-player",
  "video": "https://www.youtube.com/embed/v-PjgYDrg70", 
  "video_img": "https://img.youtube.com/vi/v-PjgYDrg70/maxresdefault.jpg",
  "title": "Toy Story Trailer"
}

@velias
Copy link
Collaborator

velias commented Oct 2, 2025

Please document video-player abilities in README.md as discussed in RedHat-UX/next-gen-ui-agent#177 .
Example is in RHDS renderer README https://redhat-ux.github.io/next-gen-ui-agent/guide/renderer/rhds/

@velias
Copy link
Collaborator

velias commented Oct 2, 2025

BTW that AI generated PR description is too long/hard to read and understand ;-) Contains lots of unnecessary or duplicate or unrelated info. Try to keep it short and with important info only to make reviewer work easier :-D

@Hrithik-Gavankar Hrithik-Gavankar marked this pull request as ready for review October 2, 2025 17:56
@Hrithik-Gavankar Hrithik-Gavankar self-assigned this Oct 2, 2025
@velias
Copy link
Collaborator

velias commented Oct 6, 2025

@grantsydney @eyevana can you review this PR also please as a FE/React experts

Copy link
Collaborator

@velias velias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all that e2e changes part of this PR? They should not be here

@Hrithik-Gavankar
Copy link
Collaborator Author

Hi @velias,

Those e2e files were present when I initially cut the branch from main, which is why they appeared in this PR.
I’ve now updated the branch with the latest main, and those changes are no longer visible.

Thank you for pointing it out!

Copy link
Collaborator

@velias velias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hrithik-Gavankar Hrithik-Gavankar merged commit 8152fc7 into main Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants