Skip to content

namespace resource: support get raw object in get() - Cherry-pick #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2021
Merged

namespace resource: support get raw object in get() - Cherry-pick #242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b06c23a
Cherry-pick #185
myakove Sep 19, 2021
a5dd540
undo changes to pre-commit-config.yaml
dbasunag Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions ocp_resources/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,13 +777,14 @@ def __init__(
self.namespace = namespace

@classmethod
def get(cls, dyn_client, singular_name=None, *args, **kwargs):
def get(cls, dyn_client, singular_name=None, raw=False, *args, **kwargs):
"""
Get resources

Args:
dyn_client (DynamicClient): Open connection to remote cluster
singular_name (str): Resource kind (in lowercase), in use where we have multiple matches for resource
raw (bool): If True return raw object from openshift-restclient-python


Returns:
Expand All @@ -794,17 +795,23 @@ def get(cls, dyn_client, singular_name=None, *args, **kwargs):
)
try:
for resource_field in _resources.items:
if raw:
yield resource_field
else:
yield cls(
client=dyn_client,
name=resource_field.metadata.name,
namespace=resource_field.metadata.namespace,
)
except TypeError:
if raw:
yield _resources
else:
yield cls(
client=dyn_client,
name=resource_field.metadata.name,
namespace=resource_field.metadata.namespace,
name=_resources.metadata.name,
namespace=_resources.metadata.namespace,
)
except TypeError:
yield cls(
client=dyn_client,
name=_resources.metadata.name,
namespace=_resources.metadata.namespace,
)

@property
def instance(self):
Expand Down