Skip to content

Logger add duplicate filter #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Logger add duplicate filter #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions ocp_resources/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,27 @@
from colorlog import ColoredFormatter


LOGGER = logging.getLogger(__name__)


class DuplicateFilter(logging.Filter):
def filter(self, record):
repeated_number_exists = getattr(self, "repeated_number", None)
current_log = (record.module, record.levelno, record.msg)
if current_log != getattr(self, "last_log", None):
self.last_log = current_log
if repeated_number_exists:
LOGGER.warning(f"Last log repeated {self.repeated_number} times.")

self.repeated_number = 0
return True
if repeated_number_exists:
self.repeated_number += 1
else:
self.repeated_number = 1
return False


def get_logger(name):
log_level = os.environ.get("OPENSHIFT_PYTHON_WRAPPER_LOG_LEVEL", "INFO")
log_file = os.environ.get("OPENSHIFT_PYTHON_WRAPPER_LOG_FILE", "")
Expand All @@ -27,9 +48,11 @@ def get_logger(name):

console_handler = logging.StreamHandler()
console_handler.setFormatter(fmt=log_formatter)
console_handler.addFilter(filter=DuplicateFilter())

logger_obj.addHandler(hdlr=console_handler)
logger_obj.setLevel(level=log_level)
logger_obj.addFilter(filter=DuplicateFilter())

if log_file:
log_handler = RotatingFileHandler(
Expand Down